More issues with archetype profile

Reference Implementation: Java (archive)
1

Hi Thomas,

More on openehr_archetype_profile:

1. The following invariant on p18 doesn't seem to be correct,
terminology_id is of type TERMINOLOY_ID, how can it be empty?

Terminology_id_valid: terminology_id /= Void implies not
(terminology_id.is_empty or code_list = Void)

2. on page 21 near the bottom, class C_DV_ORDINAL "Inherit
C_DV_ORDERED", according to the class diagram the super class should be
"C_DOMAIN_TYPE" same as the that of C_DV_QUANTITY. Otherwise,
C_DV_ORDERED should be included in the specs and the class diagram
should be updated.

regards,
Rong

2

Rong Chen wrote:

Hi Thomas,

More on openehr_archetype_profile:

1. The following invariant on p18 doesn't seem to be correct,
terminology_id is of type TERMINOLOY_ID, how can it be empty?

Terminology_id_valid: terminology_id /= Void implies not
(terminology_id.is_empty or code_list = Void)
  

Fixed. This is now:

terminology_id /= Void implies code_list /= Void

2. on page 21 near the bottom, class C_DV_ORDINAL "Inherit
C_DV_ORDERED", according to the class diagram the super class should be
"C_DOMAIN_TYPE" same as the that of C_DV_QUANTITY. Otherwise,
C_DV_ORDERED should be included in the specs and the class diagram
should be updated.
  

This is an error; it should be

C_DOMAIN_TYPE

thanks,

- thomas

3

Rong Chen wrote:

Hi Thomas,

More on openehr_archetype_profile:

1. The following invariant on p18 doesn't seem to be correct,
terminology_id is of type TERMINOLOY_ID, how can it be empty?

Terminology_id_valid: terminology_id /= Void implies not
(terminology_id.is_empty or code_list = Void)
  

Actually, this should be:
code_list /= Void implies terminology_id /= Void

- thomas