# Comments about the rm implementation

**Category:** [Reference Implementation: Java (archive)](https://discourse.openehr.org/c/reference-implementation-java-archive/154)
**Created:** 2007-10-30 10:42 UTC
**Views:** 5
**Replies:** 1
**URL:** https://discourse.openehr.org/t/comments-about-the-rm-implementation/12635

---

## Post #1 by @Sergio_M_Freire

Hello everybody,

I am new to this list.
I have been studying openEhr specifications and the corresponding java implementation and have some comments about the reference model implementation
I exchanged e-mails with Rong Chen who asked me to post them to the list so that everyone could see and comment on them.

I think that it will be more effective to post some at a time.
I will start with the support package.

**support.basic.IntervalTest**

private String testString(int[] row) {

return "(" + row[ 0 ] + ", " + row[ 1 ] + ") has " + row[ **2** ] + ": " + ( row[ **3** ] == 1 );

}

row[2] and row[3] should be row[4] and row[5] respectively.

If in method testHas I change data[0] = {1, 8, 1, 1, 2, 1} to {1, 8, 1, 1, 2, 0} to force the test fail,
I get the following message: failed at (1,8) has 1: true
where I should get: failed at (1,8) has 2: false

**support.terminology.TerminologyAccess**

It lacks operation public **boolean hasCodeForGroupId(String groupId, CodePhrase code);**

Best regards,

Sergio Miranda Freire
Assistant Professor
State University of Rio de Janeiro
Brazil

---

## Post #2 by @system

> Hello everybody,
>
> I am new to this list.
> I have been studying openEhr specifications and the corresponding java implementation and have some comments about the reference model implementation
> I exchanged e-mails with Rong Chen who asked me to post them to the list so that everyone could see and comment on them.
>
> I think that it will be more effective to post some at a time.
> I will start with the support package.

Hi Sergio,

Thanks for the report! Please find my comments below.

> **support.basic.IntervalTest**
>
> I think there is a slight mistake in method testString that does not affect test results.
>
> In method
>
> private String testString(int[] row) {
>
> return "(" + row[ 0 ] + ", " + row[ 1 ] + ") has " + row[ **2** ] + ": " + ( row[ **3** ] == 1 );
>
> }
>
> row[2] and row[3] should be row[4] and row[5] respectively.
>
> If in method testHas I change data[0] = {1, 8, 1, 1, 2, 1} to {1, 8, 1, 1, 2, 0} to force the test fail,
> I get the following message: failed at (1,8) has 1: true
> where I should get: failed at (1,8) has 2: false

Yes, you are correct! It's fixed on the TRUNK now.

> **support.terminology.TerminologyAccess**
>
> It lacks operation public **boolean hasCodeForGroupId(String groupId, CodePhrase code);**

It's added now. The description of this method seems to be quite specific to openEHR terminology. I wonder if this method could be useful for terminologies other than the openEHR one.

Cheers,
Rong

---


**Canonical:** https://discourse.openehr.org/t/comments-about-the-rm-implementation/12635
**Original content:** https://discourse.openehr.org/t/comments-about-the-rm-implementation/12635