# Comments about the rm implementation

**URL:** https://discourse.openehr.org/t/comments-about-the-rm-implementation/12635
**Category:** Reference Implementation: Java (archive)
**Created:** [30 October 2007 10:42 UTC](https://discourse.openehr.org/t/comments-about-the-rm-implementation/12635 "2007-10-30T10:42:00Z")
**Posts on this page:** 2
**Page:** 1

<div class="post-metadata">

### Author: ![Sergio\_M\_Freire](https://discourse.openehr.org/letter_avatar_proxy/v4/letter/s/82dd89/32.png) [@Sergio\_M\_Freire](https://discourse.openehr.org/u/Sergio_M_Freire)
#### Post date: [30 October 2007 10:42 UTC](https://discourse.openehr.org/t/comments-about-the-rm-implementation/12635/1 "2007-10-30T10:42:00Z")

</div>

Hello everybody,

I am new to this list.  
I have been studying openEhr specifications and the corresponding java implementation and have some comments about the reference model implementation  
I exchanged e-mails with Rong Chen who asked me to post them to the list so that everyone could see and comment on them.

I think that it will be more effective to post some at a time.  
I will start with the support package.

**support.basic.IntervalTest**

private String testString(int row) {

return “(” + row[0] + ", " + row[1] + ") has " + row[**2**] + ": " + ( row[**3**] == 1 );

}

row[2] and row[3] should be row[4] and row[5] respectively.

If in method testHas I change data[0] = {1, 8, 1, 1, 2, 1} to {1, 8, 1, 1, 2, 0} to force the test fail,  
I get the following message: failed at (1,8) has 1: true  
where I should get: failed at (1,8) has 2: false

**support.terminology.TerminologyAccess**

It lacks operation public **boolean hasCodeForGroupId(String groupId, CodePhrase code);**

Best regards,

Sergio Miranda Freire  
Assistant Professor  
State University of Rio de Janeiro  
Brazil

---

<div class="post-metadata">

### Author: ![system](https://discourse.openehr.org/uploads/default/original/2X/f/f0a1dedb20c42747bddcafd6c7df9db5f34f003c.svg) [@system](https://discourse.openehr.org/u/system)
#### Post date: [31 October 2007 09:06 UTC](https://discourse.openehr.org/t/comments-about-the-rm-implementation/12635/2 "2007-10-31T09:06:08Z")

</div>

> Hello everybody,
> 
> I am new to this list.  
> I have been studying openEhr specifications and the corresponding java implementation and have some comments about the reference model implementation  
> I exchanged e-mails with Rong Chen who asked me to post them to the list so that everyone could see and comment on them.
> 
> I think that it will be more effective to post some at a time.  
> I will start with the support package.

Hi Sergio,

Thanks for the report! Please find my comments below.

> **support.basic.IntervalTest**
> 
> I think there is a slight mistake in method testString that does not affect test results.
> 
> In method
> 
> private String testString(int row) {
> 
> return “(” + row[0] + ", " + row[1] + ") has " + row[**2**] + ": " + ( row[**3**] == 1 );
> 
> }
> 
> row[2] and row[3] should be row[4] and row[5] respectively.
> 
> If in method testHas I change data[0] = {1, 8, 1, 1, 2, 1} to {1, 8, 1, 1, 2, 0} to force the test fail,  
> I get the following message: failed at (1,8) has 1: true  
> where I should get: failed at (1,8) has 2: false

Yes, you are correct! It’s fixed on the TRUNK now.

> **support.terminology.TerminologyAccess**
> 
> It lacks operation public **boolean hasCodeForGroupId(String groupId, CodePhrase code);**

It’s added now. The description of this method seems to be quite specific to openEHR terminology. I wonder if this method could be useful for terminologies other than the openEHR one.

Cheers,  
Rong